Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warcraft logs uploader #174542

Merged
merged 4 commits into from
May 23, 2024
Merged

Warcraft logs uploader #174542

merged 4 commits into from
May 23, 2024

Conversation

phschott
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@p-linnane
Copy link
Member

Hi. Thanks for the PR. We have notability requirements for inclusion in homebrew-cask (<30 forks, <30 watchers and <75 stars), which unfortunately this software does not meet. Please consider hosting this in your own Homebrew tap instead.

@p-linnane p-linnane closed this May 22, 2024
@bevanjkay
Copy link
Member

@p-linnane I don't think the notability requirement applies here because the repository only hosts the binaries, not the source code.

@p-linnane p-linnane reopened this May 23, 2024
@bevanjkay bevanjkay added the ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually. label May 23, 2024
@miccal miccal added the awaiting user reply Issue needs response from a user. label May 23, 2024
phschott and others added 2 commits May 23, 2024 19:54
@miccal
Copy link
Member

miccal commented May 23, 2024

Thank you @phschott.

@miccal miccal merged commit 3e40b1d into Homebrew:master May 23, 2024
9 checks passed
@miccal miccal removed the awaiting user reply Issue needs response from a user. label May 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually. new cask outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants