Catch-22 adding a new formula to a tap to be bottled but running into multiple issues 😣

[ipatch]

homebrew-freecad tap maintainer here 🙋‍♂️, can't remember if I've mentioned this issue before, but definitely feels overlapping from a prior question i have asked.

TL;DR

using brew test-bot & brew pr-pull to publish bottles fails 🚫 with the below criteria

the below is based on my experience

• if a PR contains more than one commit then i am unable to build and publish a bottle for such formula contained in the PR
• if the PR modifies more than one file, ie. i've only been able to publish bottles when a PR is 1 commit with one file changed, which brings up the below issue.

with the current homebrew-freecad tap i'm attempting to add a new formula, but brew audit will fail with the below error message,

==> FAILED
Full audit --tap=freecad/freecad --except=version output
  freecad/freecad/med-file:
    * Formula has other versions so create a versioned alias:
        cd /usr/local/Homebrew/Library/Taps/freecad/homebrew-freecad/Aliases
        ln -s ../Formula/med-file.rb [email protected]
  Error: 1 problem in 1 formula detected
  Error: Formula has other versions so create a versioned alias:
    cd /usr/local/Homebrew/Library/Taps/freecad/homebrew-freecad/Aliases
    ln -s ../Formula/med-file.rb [email protected]
  
Error: 1 failed step!
brew audit --tap=freecad/freecad --except=version
Error: Process completed with exit code 1.

so i run above such commands, make brew audit happy then brew pr publish fails,

Run brew pr-pull --debug --tap=$GITHUB_REPOSITORY $PULL_REQUEST
  brew pr-pull --debug --tap=$GITHUB_REPOSITORY $PULL_REQUEST
  shell: /bin/bash -e {0}
  env:
    HOMEBREW_GITHUB_API_TOKEN: ***
    HOMEBREW_GITHUB_PACKAGES_TOKEN: ***
    HOMEBREW_GITHUB_PACKAGES_USER: ipatch
    PULL_REQUEST: 323
  
Warning: pr-pull is a developer command, so
Homebrew's developer mode has been automatically turned on.
To turn developer mode off, run brew developer off

/usr/local/Homebrew/Library/Homebrew/shims/shared/git --version
==> Fetching freecad/freecad pull request #323
/usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/3.4.11-163-g5585ec9\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 11.6.6\)\ curl/7.64.1 --header Accept-Language:\ en --retry 3 --location https://api.github.com/repos/FreeCAD/homebrew-freecad/pulls/323 --header Accept:\ application/vnd.github.v3\+json --write-out '
'\%\{http_code\} --header Accept:\ application/vnd.github.antiope-preview\+json --header Authorization:\ token\ ****** --dump-header /private/tmp/github_api_headers20220530-1410-mdtt34
/usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/3.4.11-163-g5585ec9\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 11.6.6\)\ curl/7.64.1 --header Accept-Language:\ en --retry 3 --location https://api.github.com/repos/FreeCAD/homebrew-freecad/pulls/323/commits\?per_page=100\&page=1 --header Accept:\ application/vnd.github.v3\+json --write-out '
'\%\{http_code\} --header Accept:\ application/vnd.github.antiope-preview\+json --header Authorization:\ token\ ****** --dump-header /private/tmp/github_api_headers20220530-1410-w4fjh2
==> Using 1 commit from #323
Error: Autosquash can only squash commits that modify formula or cask files.
  File:   Aliases/[email protected]
  Commit: cb156e97c90c6985c23e6b470f45bfee64c9c7a8
Error: Kernel.exit
/usr/local/Homebrew/Library/Homebrew/utils.rb:160:in `exit'
/usr/local/Homebrew/Library/Homebrew/utils.rb:160:in `odie'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:246:in `block (2 levels) in autosquash!'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:237:in `each'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:237:in `block in autosquash!'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:234:in `to_h'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:234:in `autosquash!'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:408:in `block (3 levels) in pr_pull'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8/lib/ruby/2.6.0/fileutils.rb:128:in `chdir'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8/lib/ruby/2.6.0/fileutils.rb:128:in `cd'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:402:in `block (2 levels) in pr_pull'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8/lib/ruby/2.6.0/tmpdir.rb:93:in `mktmpdir'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:401:in `block in pr_pull'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:390:in `each'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:390:in `pr_pull'
/usr/local/Homebrew/Library/Homebrew/brew.rb:110:in `<main>'
Error: Process completed with exit code 1.

obviously i could try some hacky solutions to make this work using force push or what not, but defintiely seems like issue with the publish workflow or brew audit 🤷‍♂️

[Bo98]

Yeah, autosquash currently only works when only formula files are edited. If you've got aliases, pass --no-autosquash.

It will of course take the commits as is: this will disable the feature of squashing commits together, so make sure the commits are as you'd like them to be in the PR first.

if a PR contains more than one commit then i am unable to build and publish a bottle for such formula contained in the PR

Not sure what you mean by this scenario though. Sounds like it should work fine with autosquash unless you're editing non-formula files there too?

[ipatch]

FreeCAD/homebrew-freecad#323 is the revised pr with the missing alias

below is the error message i get without the alias added to the PR ie without adding 2 distinct files to the PR

https://github.com/FreeCAD/homebrew-freecad/runs/6662860684?check_suite_focus=true

---

below is the error message i get when adding the alias to make brew audit not fail

https://github.com/FreeCAD/homebrew-freecad/runs/6661864073?check_suite_focus=true

thus making the brew pr brew publish fail