Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/gems: prioritise Homebrew's chosen Ruby #7284

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Apr 5, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As seen in #5561 (comment), Ruby in other locations like rbenv may be used when installing gems. At the very least, this can mean installing native extensions to a place that won't match what Homebrew's chosen Ruby actually uses. At worst, we get hard to debug errors.

The reason other Rubys were being picked was because ~/.gem/2.6.0/bin was prioritised over Homebrew's chosen Ruby bin directory. This may mean that ~/.gem/2.6.0/bin/bundle is run instead.

This is a separate issue to the TMPDIR one.

@MikeMcQuaid
Copy link
Member

Makes sense, thanks @Bo98.

@MikeMcQuaid MikeMcQuaid merged commit 91d506b into Homebrew:master Apr 5, 2020
@Bo98 Bo98 deleted the gems-path branch April 5, 2020 15:29
@lock lock bot added the outdated PR was locked due to age label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants