-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker images have expired key for github cli packages #18268
Comments
Is there another keyring we can get that isn't expired?
Homebrew CI makes heavy use of
Not without breaking pretty much all of our CI. |
See also cli/cli#9569. Seems like the image just needs to be rebuilt. If this is blocking you, consider using A rebuilt In a pinch, you could probably also run this inside the
|
Hi folks, many apologies for the troubles from the GitHub CLI. I just added some docker related details to our tracking issue: cli/cli#9569 (comment) I can confirm the new keyring is available at https://cli.github.com/packages/githubcli-archive-keyring.gpg. If you own the layer that grabs this key, I would expect rebuilding the image solves the problem. If you don't own the layer, running:
Before the Sorry 🙏 |
@williammartin thanks for chiming in! I think Lines 47 to 51 in 94eb0c7
I'll open a PR to update our |
Ahha! Thanks. I'm going to update our issue to provide both sets of instructions. |
Thank you @carlocab ! We're good on our side. We have a hotfix to remove everything gh (via apt; we also make use of gh, but we install it via homebrew 😅 #inception) And thank you @williammartin ! Do take it easy and enjoy the weekend! ❤️ |
Updated the instructions to account for the old location here: cli/cli#9569 (comment) Cheers! |
Thanks @williammartin! |
This should be fixed as of https://github.com/Homebrew/brew/releases/tag/4.3.20. |
brew doctor
outputVerification
brew doctor
output" above saysYour system is ready to brew.
and am still able to reproduce my issue.brew update
twice and am still able to reproduce my issue.brew install wget
. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.brew config
outputWhat were you trying to do (and why)?
use the latest homebrew docker image and get the latest aptitude packages
In
brew/Dockerfile
Line 47 in 94eb0c7
so running
Followed by an apt-get update, like
will now error.
Any other fix than build a new image or rebuild the current image (same version)?
For the time being, I guess it can be fixed downstream by updating the keyring.
PS: Maybe someone can explain why do we need github cli on the homebrew docker image. Can it be removed?
What happened (include all command output)?
What did you expect to happen?
no error
Step-by-step reproduction instructions (by running
brew
commands)docker run --rm -it ghcr.io/homebrew/ubuntu22.04:latest # inside docker, run: sudo apt-get -y --fix-missing --allow-releaseinfo-change update
The text was updated successfully, but these errors were encountered: