Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualenv_create with options. #1790

Closed
devgeist42 opened this issue Jan 5, 2017 · 9 comments
Closed

virtualenv_create with options. #1790

devgeist42 opened this issue Jan 5, 2017 · 9 comments
Labels
features New features

Comments

@devgeist42
Copy link

Currently, virtualenv_create does not accept any extra options. For packages that depend on python modules in homebrew/python, such as numpy, etc., passing --system-site-packages to virtualenv should be useful.

@MikeMcQuaid MikeMcQuaid added the features New features label Jan 7, 2017
@MikeMcQuaid
Copy link
Member

Will want @tdsmith's input on this.

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 7, 2017

I think we already add them if they're declared as dependencies.

@tdsmith
Copy link
Contributor

tdsmith commented Jan 7, 2017

Thanks for the comment. Declared dependencies should already be accessible from the virtualenv; that's handled here: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/language/python.rb#L126

If it isn't working, please open a ticket.

@tdsmith tdsmith closed this as completed Jan 7, 2017
@kyungminlee
Copy link

I see. At the moment virtualenv_create only looks at formulae; python module dependencies are not accessible inside virtualenv. Is it be possible to make the python module deps available inside virtualenv?

@tdsmith
Copy link
Contributor

tdsmith commented Jan 9, 2017 via email

@kyungminlee
Copy link

Even if you have depends_on "numpy" => :python in your formula, numpy is not accessible in the virtualenv.

@tdsmith
Copy link
Contributor

tdsmith commented Jan 9, 2017 via email

@kyungminlee
Copy link

I see. That's what I thought. Thanks!

@MikeMcQuaid
Copy link
Member

@kyungminlee It's worth noted that depends_on "numpy" => :python is somewhat deprecated (and I've made a note to officially deprecate it).

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features New features
Projects
None yet
Development

No branches or pull requests

5 participants