CI experiences failures due to Homebrew being removed from $PATH on GitHub runners

[p-linnane]

brew config output

N/A

brew doctor output

N/A

Verification

• I ran brew update and am still able to reproduce my issue.
• I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?

CI that uses the 20220922.2 Ubuntu image fails due to GitHub removing Homebrew from $PATH.

actions/runner-images#6283

What happened (include all command output)?

CI fails if it uses the 20220922.2 Ubuntu runner image.

What did you expect to happen?

CI succeeds or fails

Step-by-step reproduction instructions (by running brew commands)

Example: Homebrew/homebrew-cask#132241

[carlocab]

CC @Homebrew/linux. See, in particular: actions/runner-images#6283, actions/runner-images#6280

[mikhailkoliada]

Hey!

Yeah, we had to remove brew from PATH on linux despite all the efforts, we can not predict how people parse tooolchain or the system variables in their code, which caused us some painful issues and I do not think it is an issue you guys can help with, as the usage can be totally arbitrary and purely depends on the design of an end customer.

[MikeMcQuaid]

@mikhailkoliada Is this only for Ubuntu <22.04? Do you have any ideas/dates when 22.04 will become ubuntu-latest?

[mikhailkoliada]

@MikeMcQuaid currently these are all ubuntus, for consistency. We are planning to migrate ubuntu-22.04 to latest next quarter.

[MikeMcQuaid]

@mikhailkoliada I cannot reproduce this, it seems Ubuntu 22.04 still has brew in the PATH. Can you confirm if that will change or not?

We are planning to migrate ubuntu-22.04 to latest next quarter.

Thanks!

[mikhailkoliada]

@MikeMcQuaid for 22.04 changes will be rolled out this week probably too, last week we had to fix only 18.04 and 20.04 quickly due to direct impact

[p-linnane]

There are an increasing number of PR's in homebrew-cask are are failing due to this change.

[carlocab]

I do not think it is an issue you guys can help with

Actually, actions/runner-images#6280 looks like something we can and should fix, since gcc-12 should still be working despite glibc being keg-only.

[mikhailkoliada]

@carlocab I am afraid it is the tip of the iceberg. We had reports where customers (including premium ones) did not expect to have toolchain other than from Ubuntu's repo being present in the runner at all, i.e. it is not even a problem that gcc-12 does not work, the problem is that exists, say, in $PATH

[carlocab]

i.e. it is not even a problem that gcc-12 does not work, the problem is that exists, say, in $PATH

You had the exact same issue with glibc and binutils, which we fixed. Why do you say that we would not be able to fix this one?

[MikeMcQuaid]

@mikhailkoliada The issue was presumably with it (gcc) being in the PATH rather than existing on disk at all and that it was baked in on the image even when Homebrew on Linux hadn't been run by that customer. Some potential mitigations:

• make gcc keg-only so it's not in the PATH even when brew is
• GitHub doesn't auto-install e.g. zstd which will pull in this compiler
• Remove from PATH on ubuntu-latest but not ubuntu-22.04 (and not when that becomes ubuntu-latest, either)

[sjackman]

• GitHub doesn't auto-install e.g. zstd which will pull in this compiler
• Remove from PATH on ubuntu-latest but not ubuntu-22.04 (and not when that becomes ubuntu-latest, either)

Both of these suggestions sound good to me.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[MikeMcQuaid]

We have mitigated this with the Homebrew/setup-homebrew action. We don't control what GitHub Actions does so have no ability to influence beyond that.

[armanbilge]

Dumb question: where is said action?
https://github.com/Homebrew/setup-homebrew

[MikeMcQuaid]

https://github.com/Homebrew/actions/tree/master/setup-homebrew