Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--system-site-packages should be customizable by virtualenv_create #11885

Closed
jiasli opened this issue Aug 19, 2021 · 1 comment · Fixed by #12101
Closed

--system-site-packages should be customizable by virtualenv_create #11885

jiasli opened this issue Aug 19, 2021 · 1 comment · Fixed by #12101
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age

Comments

@jiasli
Copy link

jiasli commented Aug 19, 2021

Provide a detailed description of the proposed feature

#11611 specifies --system-site-packages when creating a virtual environment. This makes Azure CLI installed by Homebrew conflict with Ansible collection for Azure installed to system site-packages using pip. (Azure/azure-cli#19027, Homebrew/discussions#2009).

This makes Homebrew less flexible, even though it fixes #1790.

What is the motivation for the feature?

To makes Homebrew more flexible.

How will the feature be relevant to at least 90% of Homebrew users?

No

What alternatives to the feature have been considered?

Let the users create virtual env by themselves when installing with pip.

@jiasli jiasli added the features New features label Aug 19, 2021
@carlocab
Copy link
Member

I had come to the same conclusion after our discussion at Homebrew/discussions#2009. This would be good to have, and should be straightforward to implement.

@MikeMcQuaid MikeMcQuaid added the help wanted We want help addressing this label Aug 19, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants