setup-homebrew: source homebrew from standard locations #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Sep 26, 2022
There was a problem hiding this comment.
Thanks for this. I still think we should probably:
- print a warning letting people know that the Ubuntu 22.04 is a better fit and will be significantly faster using Homebrew there
- audit and fix all our usage of
ubuntu-latestwhere we rely onbrewbeing in thePATHand move to Ubuntu 22.04
Co-authored-by: Mike McQuaid <[email protected]>
SMillerDev
commented
Sep 26, 2022
MikeMcQuaid
approved these changes
Sep 26, 2022
|
Will a rebuild fix the GCC style audit failure? |
I don't know, but I know exempting |
|
Oh, actually, this will be fixed by Homebrew/brew#13916 too. |
7 tasks
|
I suggest skipping the tap-syntax test on diff --git a/.github/workflows/setup-homebrew.yml b/.github/workflows/setup-homebrew.yml
index a519112..ee64725 100644
--- a/.github/workflows/setup-homebrew.yml
+++ b/.github/workflows/setup-homebrew.yml
@@ -45,3 +45,4 @@ jobs:
- run: brew test-bot --only-setup
- run: brew test-bot --only-tap-syntax
+ if: matrix.os != 'ubuntu-latest'
|
carlocab
approved these changes
Sep 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the problem introduced by actions/runner-images#6283