Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_EncodedFrameTop / Bottom maybe wrong? #32

Closed
MIRIMIRIM opened this issue May 21, 2023 · 5 comments
Closed

_EncodedFrameTop / Bottom maybe wrong? #32

MIRIMIRIM opened this issue May 21, 2023 · 5 comments

Comments

@MIRIMIRIM
Copy link

MIRIMIRIM commented May 21, 2023

I have such a clip

Source Frame 0 1 2 3
TFF flag 1 1 0 0
RFF flag 0 1 0 1
Field 0t 0b 1t 1b 1t_r 2b 2t 3b 3t 3b_r
Decode Frame 0 1 2 3 4

Top three columns are from clip headers, field column is the result I think we should get. “_r” means repeat.

_EncodedFrameTop [int], _EncodedFrameBottom [int]
Frame number (before pulldown) used to generate this frame's top/bottom field.

But I got the following props when use LWLibavVideoSource(clip, repeat=True):

frame _EncodedFrameTop _EncodedFrameBottom
0 0 0
1 1 1
2 2 2
3 2 3
4 3 4

I’m not sure what went wrong.

@Asd-g
Copy link
Contributor

Asd-g commented May 22, 2023

Can you share a short sample?

@MIRIMIRIM
Copy link
Author

I use mmg trim the first few frames from the original DVD source

sample.zip

@Asd-g
Copy link
Contributor

Asd-g commented May 27, 2023

Thanks.

@Asd-g
Copy link
Contributor

Asd-g commented May 29, 2023

Try the attached test version.

Use ffprobe -show_frames sample.mkv to get the frames metadata.

LSMASHSource.zip

@MIRIMIRIM
Copy link
Author

Thank you for the fix, at the same time I realized that I was looking at the wrong order of frames and have fixed the issue description.

@Asd-g Asd-g closed this as completed in 9b23bbd Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants