-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Z-module structure on abelian groups #1992
base: master
Are you sure you want to change the base?
Conversation
- assumption. | ||
- snrapply (Build_IsLeftModule _). | ||
+ intros n a. exact (ab_mul n a). | ||
+ unfold LeftHeteroDistribute. intros n. exact preserves_sg_op. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is grp_homo_op
. We define ab_mul
as a map from Z to group endomorphisms. This means that the left dist property for modules is just the group homomorphism preserving the operation.
Actually it seems we are missing a lot (in the existing library) here which is a shame. I think the best way forward would be to try to generalise what I've called The issue with this however is that I would like to switch from BinInt to Int soon, which should simplify the proofs here. So maybe we should hold off on this for the time being until we clean that up. Thank you for taking a look at this however. |
|
||
Section Lm_carrierIsEquiv. | ||
|
||
(** lm_carrier is a 1-functor (LeftModule R) -> AbGroup. *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment style as I mentioned in the other PR. I'll let you check all comments.
In fact, as far as I can see, |
We should probably call this |
@jdchristensen Yes, we could do this immediately. I can work on that today if you like. |
Sounds good to me, unless you think it might be a good thing for @ThomatoTomato to tackle (with an outline of what is needed). Probably we want to implement and use something like what is in Spaces/BinInt/Equiv.v, using that in a group, multiplication by a fixed element is an equivalence. (OTOH, if we define |
Ah, I see that you already started on this, asking @ThomatoTomato for help. |
I created #1995 which is partially finished. |
We want to make lm_carrier into an equivalence of categories.
Pipeline: