Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: user-provided spectra in temperature response functions #51

Open
kreevescfa opened this issue May 27, 2022 · 3 comments
Labels
enhancement New feature or request response Issues related to the response subpackage
Milestone

Comments

@kreevescfa
Copy link

Right now temperature response functions read spectra out of a gene file. We would like to expand the functionality so that a user can optionally supply their own spectra.

@namurphy namurphy added this to the 0.2.0 milestone Jun 24, 2022
@wtbarnes
Copy link
Collaborator

Very similar thread on the aiapy repo: https://gitlab.com/LMSAL_HUB/aia_hub/aiapy/-/issues/23#note_296346341.
I had scoped out a similar though slightly more abstract plan to have an EmissionModel object, composed of some number of ions and perhaps transitions per ion, that the user could construct and then pass in to some temperature response function. This would allow you to build up the inputs to your temperature response model in a very natural way. The missing piece in that effort was how to generate that spectra (or list of emissivities).

@kreevescfa
Copy link
Author

kreevescfa commented Jun 29, 2022 via email

@wtbarnes
Copy link
Collaborator

wtbarnes commented Jul 3, 2022

I believe chiantipy could definitely do that. I was thinking in the same vein. The EmissionModel could just be general interface for specifying the spectrum, regardless of how that spectrum was generated.

@wtbarnes wtbarnes added enhancement New feature or request response Issues related to the response subpackage labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request response Issues related to the response subpackage
Projects
None yet
Development

No branches or pull requests

3 participants