Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project name repeats in generated items names like: ImPlot.ImPlotGetPlot #15

Closed
J8-8N opened this issue Sep 15, 2024 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@J8-8N
Copy link

J8-8N commented Sep 15, 2024

Hello, thank you for the awesome up-to-date bindings. In ImPlot, files functions.125.cs and functions.126.cs it seems the generator didn't remove the project name from the names of items so a very common method like ImPlot::GetPlot() became ImPlot.ImPlotGetPlot() instead of ImPlot.GetPlot(). And all the other items in those files too. Thank you

@J8-8N J8-8N changed the title Names repeat in some methods Project name repeats in generated items names like: ImPlot.ImPlotGetPlot Sep 15, 2024
@JunaMeinhold JunaMeinhold added the enhancement New feature or request label Sep 15, 2024
@JunaMeinhold JunaMeinhold self-assigned this Sep 15, 2024
@JunaMeinhold
Copy link
Member

Thanks for pointing that out. I fixed it right now, you just have to wait until the nuget packages are available.

@J8-8N
Copy link
Author

J8-8N commented Sep 16, 2024

Thank you! In ImPlot functions.124.cs line 1799 I think public static ImDrawList* GetPlotDrawList() should return ImDrawListPtr instead to suit how the Hexa.Net.ImGui does similar GetDrawList methods.

@JunaMeinhold
Copy link
Member

Fixed it, i will wait for your reply if there is anything else that catches your eye before releasing it, I don't want to annoy people by very frequent updates. And additionally you can just implicitly cast it to ImDrawListPtr when doing

ImDrawListPtr draw = ImPlot.GetPlotDrawList();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants