Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple assignment indentation behavior changed #208

Open
dashkb opened this issue Oct 15, 2020 · 0 comments
Open

Multiple assignment indentation behavior changed #208

dashkb opened this issue Oct 15, 2020 · 0 comments

Comments

@dashkb
Copy link

dashkb commented Oct 15, 2020

I use vim-polyglot and so only discovered this plugin today - thank you @HerringtonDarkholme for this fantastic work!

It looks like #197 introduced a change in the way comma-separated assignments are indented. I'm not sure if this was intentional or not, but it surprised me (and I prefer the pre-change behavior) so I tracked it down. It's not clear to me what was fixed in #197 but it looks like the solution specifically targets commas? Seems like that regex needs a bit more fiddling. I see that there's test coverage, so I'll open a PR with a failing test and see if I can fix it.

Here's what I'm seeing:

It's also broken in JSON / object literals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant