Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Flatpak preparations #515

Merged
merged 34 commits into from
Mar 7, 2022
Merged

[Linux] Flatpak preparations #515

merged 34 commits into from
Mar 7, 2022

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Jul 3, 2021

Flatpak builds to be, ideally, published to Flathub.

@flavioislima flavioislima added pr:wip WIP, don't merge. pr:testing This PR is in testing, don't merge. labels Jul 3, 2021
@iMonZ
Copy link

iMonZ commented Aug 30, 2021

Any Update here?

Copy link

@iMonZ iMonZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be:
- --socker=wayland
In flatpak/org.heroic.yml
Don't miss that

@flavioislima
Copy link
Member Author

Any Update here?

So far: Heroic opens and I can Login, but it get stuck on the listing games part. I'm not sure if in a flatpak container Heroic will be able to execute legendary, it seems that is the issue but I need to investigate more.

@Doomsdayrs
Copy link

Why not just compile legendary and bundle it with the application?

@JakobDev
Copy link
Contributor

Why not just compile legendary and bundle it with the application?

It's against the rules of Flathub

@flavioislima
Copy link
Member Author

Why not just compile legendary and bundle it with the application?

It's against the rules of Flathub

Really? Didn't know that and Heroic already bundles the legendary binary.
So we would need to add it as a dependency to be downloaded during the installation or legendary would need to be on flathub for us to do some kind of integration?

@JakobDev
Copy link
Contributor

Flathub does not allow the use of pip install during instalations. The use of a network connection is not allowed during build I already ask for some of my Apps. You have to include all the whole dependency tree in the manifest. It's a lot of fun for me (not) to figure out how to build Qt from source or to figure out, why a build system that I never heard of before is not working during a Fltpak build.

Luckily for you, legendary depends only on requests, which is no problem to include in a Flatpak. More Luckily for you, there is already a person who has a legendary Flatpak, but without working wine yet. You should try to contact him.

@Eric1212 Eric1212 mentioned this pull request Jan 1, 2022
electron/constants.ts Outdated Show resolved Hide resolved
flatpak/org.heroic.yml Outdated Show resolved Hide resolved
flatpak/org.heroic.yml Outdated Show resolved Hide resolved
flatpak/org.heroic.yml Outdated Show resolved Hide resolved
@catsout
Copy link

catsout commented Jan 8, 2022

@flavioislima
Why not open a pr on flathub?
Flathub's people can help you there.

@flavioislima
Copy link
Member Author

@flavioislima Why not open a pr on flathub? Flathub's people can help you there.

Yes, good idea. We have a post on flathub forum but no one answered there yet.
I'll make more tests and will open a PR there.

@flavioislima
Copy link
Member Author

@mirkobrombin @gasinvein
Hey guys!
I finally could fix the issues with the build (wrong config path, etc).
most of the things are working now except launching games (wine issue)
But before opening a PR on Flathub can you guys take a look one more time if something can be improved?

Thanks :D

@mirkobrombin
Copy link

@mirkobrombin @gasinvein Hey guys! I finally could fix the issues with the build (wrong config path, etc). most of the things are working now except launching games (wine issue) But before opening a PR on Flathub can you guys take a look one more time if something can be improved?

Thanks :D

I'll take a look at it this weekend. Do legendary logs work now?

@flavioislima
Copy link
Member Author

I'll take a look at it this weekend. Do legendary logs work now?

Yes, I can see the output on the log screen now.

@mirkobrombin
Copy link

Nice 😎

@mirkobrombin
Copy link

Just an update: I've made some tests but legendary keep crashing. I'm trying to use legendary as flatpak to understand if it's a heroic problem or legendary one.

@flavioislima
Copy link
Member Author

Just an update: I've made some tests but legendary keep crashing. I'm trying to use legendary as flatpak to understand if it's a heroic problem or legendary one.

That's weird. can you see any log of those crashes?
can you try removing the .config/legendary and .config/heroic folders under .var/app/org.hgl.heroic/config/ ?

@mirkobrombin
Copy link

mirkobrombin commented Feb 17, 2022

Just an update: I've made some tests but legendary keep crashing. I'm trying to use legendary as flatpak to understand if it's a heroic problem or legendary one.

That's weird. can you see any log of those crashes? can you try removing the .config/legendary and .config/heroic folders under .var/app/org.hgl.heroic/config/ ?

I had some permission overrides from old tests. After cleaning up everything including the configuration files, I am no longer able to log in via Epic.

Legendary logs says I'm logged in:

(19:16:12) INFO:    [Legendary]:       finished login
(19:16:12) INFO:    [Frontend]:        Refreshing Library
(19:16:12) INFO:    [Legendary]:       Refreshing library...
(19:16:12) INFO:    [Frontend]:        No cache found, getting data from legendary...
(19:16:12) INFO:    [Legendary]:       Refreshing library...

but Heroic keep ask for login. There are other files I should clean? I've also performed a full reset from Heroic.

@flavioislima flavioislima changed the title Flatpak config [Linux] Flatpak preparations Mar 7, 2022
@flavioislima flavioislima merged commit f2ff9c2 into main Mar 7, 2022
@flavioislima flavioislima deleted the flatpak_config branch March 7, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:testing This PR is in testing, don't merge. pr:wip WIP, don't merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants