Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *getunitparam to obtain values set via unit_parameters_db.conf in scripts #3323

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

skyleo
Copy link
Contributor

@skyleo skyleo commented Sep 21, 2024

Pull Request Prelude

Changes Proposed

Add a new script command named getunitparam to obtain the values set via unit_parameters_db.conf which used to be obtainable via getbattleflag(...)

In relation to: #3214

NOTE: The deprecation warning of the deprecated keys for the battle flags, is not shown when using getbattleflag(..), but zero (or the default value) is silently returned instead.

Issues addressed: None

@skyleo skyleo requested a review from guilherme-gm September 21, 2024 05:40
Copy link
Member

@guilherme-gm guilherme-gm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that small detail, looks good to me

doc/script_commands.txt Outdated Show resolved Hide resolved
@skyleo skyleo force-pushed the add-getunitparam-scriptcmd branch from 285b528 to 7b6437f Compare September 21, 2024 16:34
@skyleo skyleo requested a review from guilherme-gm September 21, 2024 16:34
@MishimaHaruna MishimaHaruna added this to the Release v2024.09 milestone Sep 28, 2024
src/map/script.c Show resolved Hide resolved
@skyleo skyleo force-pushed the add-getunitparam-scriptcmd branch from 7b6437f to 1adb7c6 Compare September 29, 2024 18:30
@MishimaHaruna MishimaHaruna merged commit 60f3f74 into HerculesWS:master Sep 29, 2024
276 of 316 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants