Don't use SSL for MariaDB CI runs (Fixes CI) #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the version of MariaDB used in CI doesn't starts with SSL enabled, and we don't need it.
MishimaHaruna
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
The mysql client currently being used for MariaDB CI runs tries to connect with SSL to the test db. But our test db does not run in SSL (and doesn't have to).
This PR disables the SSL connection for MariaDB tests.
I had to limit to MariaDB v11 as some other tests (specially using MySQL) would fail because
--sslis not recognized by them.Issues addressed: