Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sysinfogen.sh get incorrect synctax SYSINFO_CPUCORES #3271

Merged

Conversation

vietlubu
Copy link
Contributor

Pull Request Prelude

Issue:

When trying to run make. sysinfo.inc will be generated.
I'm using Mac M1 the output of SYSINFO_CPUCORES is

// CPU Cores (Platform-dependent)
#define i ( 10 (8 performance and 2 efficiency) )

That will be make error while compile process:

sysinfo.c:1020:25: error: expected ')'
        sysinfo->p->cpucores = SYSINFO_CPUCORES;
                               ^
../common/sysinfo.inc:33:34: note: expanded from macro 'SYSINFO_CPUCORES'
#define SYSINFO_CPUCORES ( 10 (8 performance and 2 efficiency) )
                                 ^
sysinfo.c:1020:25: note: to match this '('
../common/sysinfo.inc:33:31: note: expanded from macro 'SYSINFO_CPUCORES'
#define SYSINFO_CPUCORES ( 10 (8 performance and 2 efficiency) )
                              ^
1 error generated.
make[1]: *** [obj_all/sysinfo.o] Error 1
make: *** [common_sql] Error 2

Changes Proposed

Add quotation marks to call HERC_CORES in sysinfogen.sh

Issues addressed: no

sysinfogen.sh Outdated Show resolved Hide resolved
@MishimaHaruna MishimaHaruna changed the base branch from stable to master February 4, 2024 23:19
@MishimaHaruna MishimaHaruna added this to the Release v2024.02 milestone Feb 4, 2024
@MishimaHaruna MishimaHaruna merged commit 4f6fcb5 into HerculesWS:master Mar 30, 2024
207 of 336 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants