Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MO_TRIPLEATTACK animation, one cell movement, PA_SACRIFICE delay #3259

Merged
merged 6 commits into from
Dec 29, 2023

Conversation

csnv
Copy link
Contributor

@csnv csnv commented Dec 4, 2023

Pull Request Prelude

Changes Proposed

  • Fix MO_TRIPLEATTACK animation not working when there's no possible chainable combo skill.
  • Fix one cell movements when the target cell is occupied by an invisible object (like a gm using the hide atcommand).
  • Remove incorrect afterCastActDelay in PA_SACRIFICE for pre-re.
  • Removed fixed target on some combo skills. Monk skills act on the current targeted enemy even if last skill was used on a different enemy. Proof https://www.youtube.com/watch?v=XuQ775Eu9-o thanks to akiyammio.
    All combo skills are set to current enemy unless we can prove otherwise.
  • Fixed attackabletime being overwritten when an autotriggered skill increased the timing (e.g. MO_TRIPLEATTACK)
  • Fixed combo delays applying to all SC_COMBOATTACK based skills and not sending the proper time to client.

Issues addressed:

@csnv csnv changed the title Fix MO_TRIPLEATTACK animation and one cell movements over invisible objects Fix MO_TRIPLEATTACK animation, one cell movement, PA_SACRIFICE delay Dec 4, 2023
@csnv csnv force-pushed the fix/triplea_hiddenobj branch from a76b03d to 2517f07 Compare December 18, 2023 20:25
@MishimaHaruna MishimaHaruna added this to the Release v2023.12 milestone Dec 27, 2023
src/map/clif.c Outdated Show resolved Hide resolved
@csnv csnv force-pushed the fix/triplea_hiddenobj branch from 4dab36c to 0a9c58c Compare December 29, 2023 02:11
@MishimaHaruna MishimaHaruna merged commit 8625477 into HerculesWS:master Dec 29, 2023
251 of 256 checks passed
@csnv csnv deleted the fix/triplea_hiddenobj branch January 19, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants