Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed foods and cash foods being applied simultaneously #3250

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

csnv
Copy link
Contributor

@csnv csnv commented Nov 10, 2023

Pull Request Prelude

Changes Proposed

Fixes stat foods and stat cash foods being applied simultaneously and stacked one in top of the other. Also, only cash foods can overwrite normal foods (and not the other way around) according to @Kenpachi2k13 in this old PR #2741

In addition, being the lesser evil, in this PR cash foods will overwrite the same type of food if the level is also the same. However, according to this comment in the aforementioned PR, cash foods should only overwrite stat foods if the effect is stronger, not equal. Please, let me know if I should respect the quoted behavior and not let foods be overwriten by foods of equal level.

Also the the old effect will only be canceled if the new one is stronger. Using +1 STR cash food won't cancel +1 STR normal food.

Issues addressed:
#2489

@csnv csnv force-pushed the fix/cash-food-overwrite branch from 211602f to 6acf167 Compare November 10, 2023 10:41
@MishimaHaruna MishimaHaruna added this to the Release v2023.12 milestone Nov 28, 2023
@MishimaHaruna MishimaHaruna merged commit fc46be4 into HerculesWS:master Dec 26, 2023
222 of 255 checks passed
@csnv csnv deleted the fix/cash-food-overwrite branch January 19, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants