Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config option to keep direction for free cells #3242

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

csnv
Copy link
Contributor

@csnv csnv commented Oct 29, 2023

Pull Request Prelude

Changes Proposed

Added configuration option keep_dir_free_cell. Although it is set to false, I would like it to be enabled by default in Hercules.
This option allows discovery of free cells based on the unit's current facing direction instead of always using EAST, which have the following advantages:

  • Improves distribution of mobs when dispersing after being grouped. This setting allows monsters to spread in a circular fashion instead of forming a long horizontal line.
  • Allows characters to move more naturally if they came from the east, instead of walking back.
  • In some instances, fixes issue Unable to get item #1241 allowing the user to obtain the item.

This commit also fixes #1241 in all scenarios not allowing the character to enter a walk loop. Fix based on rAthena's.

Issues addressed:
#1241

@skyleo
Copy link
Contributor

skyleo commented Oct 29, 2023

Love the idea!

src/map/clif.c Show resolved Hide resolved
@csnv csnv force-pushed the feature/keep-dir-free-cell branch from d8df290 to 0f7e220 Compare October 29, 2023 12:57
@skyleo skyleo added the hacktoberfest-accepted Easy-to-tackle issues label Nov 2, 2023
@MishimaHaruna MishimaHaruna merged commit 7d6b0b2 into HerculesWS:master Nov 19, 2023
239 of 254 checks passed
@MishimaHaruna MishimaHaruna added this to the Release v2023.11 milestone Nov 28, 2023
@csnv csnv mentioned this pull request Jan 8, 2024
3 tasks
@csnv csnv deleted the feature/keep-dir-free-cell branch January 19, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Easy-to-tackle issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants