Actions fixes and using "controller" for PRs #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replacing "github.workflow" replacer with a hardcoded name of the flow file. "github.workflow" value comes from the caller. When controller workflow is the one triggering, all flows will get this as "controller" and tests with the same matrix will conflict and cancel each other. Hardcoding the flow name allows all of them to run. - use "_" as separator between matrix values instead of "-" to make it easier to read flow ids generated by Actions, since our matrix also uses "-" in its values
for reasons unknown, the controller workflow was only used by pushes, while all workflows were triggered separately for pull requests. now both pushes and pull requests follow the same CI flow, with some specifics for pushes being handled with ifs
4144
approved these changes
Nov 5, 2023
MishimaHaruna
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
A few more updates for our CI in Actions.
Fix one issue that made pushes to master (e.g. for release) skip several tests (regression from Fixes to itemlink and fixes/improvements to CI #3238 ). Pushes unexpectedly uses the "controller" as workflow for every test, and this made some tests get the same key and cancel each other. We now have proper names for each test.
Updated how PR tests are run to also use "controller" so we get the same flow for direct pushes and PRs. Note that the bot will still only trigger for master (due to the "if" condition in it).
Issues addressed: