De-hardcode skill range modifier in skill_get_range2. #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4144
requested changes
Sep 22, 2021
MrKeiKun
force-pushed
the
update-hardcoded_range2
branch
from
1bbb83f to
045b491
Compare
4144
requested changes
Sep 22, 2021
…for sd then do the inf check.
MrKeiKun
force-pushed
the
update-hardcoded_range2
branch
from
045b491 to
7221682
Compare
4144
approved these changes
Sep 23, 2021
MishimaHaruna
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Moved hard coded skill based range modifier to
skill_db.confIssues addressed: