Add 3th missing jobs and do some other small fixes #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4144
force-pushed
the
fixjobs
branch
4 times, most recently
from
7646527 to
c4909e5
Compare
|
Nice :) |
|
skills? no. it add jobs/configs etc. |
Jedzkie
reviewed
Mar 20, 2021
ghost
reviewed
Mar 23, 2021
Also in errors with duplicated constants show word 'same', if old and new values is same.
Unused in code.
Also use ENUM_DEFINE macro for each job enum member.
This option prevent use non all enums members in switch blocks. This allow find missing case blocks in switch if enum used. Add exception into libbacktrace due foring code.
MishimaHaruna
requested changes
Apr 5, 2021
MishimaHaruna
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Add missing 3th jobs and baby jobs.
Add enum values for new 4th stats.
Add some checks for missing job data.
Convert SP_ enum into plain list.
Convert JOB_ enum into macro list and use in some functions.
Add warning if in switch used not all enum values.