Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible use after free in unit_skilluse_id2 #2947

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Fix possible use after free in unit_skilluse_id2 #2947

merged 1 commit into from
Mar 8, 2021

Conversation

4144
Copy link
Contributor

@4144 4144 commented Feb 11, 2021

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Fix possible use after free in unit_skilluse_id2.

@tlacson7
Copy link

is this related to #2925?

@4144
Copy link
Contributor Author

4144 commented Feb 11, 2021

i think no
here was issue with mob

@MishimaHaruna MishimaHaruna added this to the Release v2021.03.08 milestone Mar 8, 2021
@MishimaHaruna MishimaHaruna merged commit fed80d5 into HerculesWS:master Mar 8, 2021
@4144 4144 deleted the fixskilluse branch March 8, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v2021.03.08
Development

Successfully merging this pull request may close these issues.
3 participants
@4144 @tlacson7 @MishimaHaruna