Fixes #2489

[Jedzkie]

Pull Request Prelude

• I have followed proper Hercules code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Issues addressed:
#2489

[Kenpachi2k13]

Please use a more descriptive title for your PR.

[Emistry]

remove cash food when the normal food end?
perhaps it should be do not add the status if player already has cash food status?

remove a cash food when normal food expired, doesn't sound like it should happen.
after all player are most likely paid to obtain cash food in official server, and a non-paid item terminate a paid item, doesn't seem good approach?

[Kenpachi2k13]

@Emistry
status_end_sc_before_start() ends - as the name says - a status before starting another one.
In this case it would end SC_FOOD_STR_CASH prior to starting SC_FOOD_STR for example.

But in spite of that you're right. I did a test on Aegis and the behaviour is different.
Using a cash food cancels the effect of normal food but not vice versa.
Also the the old effect will only be canceled if the new one is stronger. Using +1 STR cash food won't cancel +1 STR normal food.
The item is used regardless of successfully applying the effect or not. This applies for normal and cash food items.

Removed approval.

[Jedzkie]

Closing this PR, replacing with new one.