Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart Tornado formula is wrong #659

Closed
Historica opened this issue Aug 23, 2015 · 3 comments
Closed

Cart Tornado formula is wrong #659

Historica opened this issue Aug 23, 2015 · 3 comments
Labels
component:mechanics Affecting the game mechanics in general type:bug Issue is a bug or describes an incorrect behavior that should be fixed

Comments

@Historica
Copy link

On Hercules this skill damage become insane when Genetic reach 149 or more total str. The current formula from repository take total str while in official it use base str.

Current repository battle.c
skillratio = 50 * skill_lv + (sd ? sd->cart_weight : battle_config.max_cart_weight) / 10 / max(150 - strbonus, 1) + 50 * (sd ? pc->checkskill(sd, GN_REMODELING_CART) : 5);

With that formula a 149 or more total str Genetic will get (250+10500+250)% skill ratio. This should be 150 minus base str like official so 130 base str Genetic will get (250+525+250)% skill ratio

@sagunkho
Copy link
Member

int strbonus = bst->str;
bst invokes base_status.

Can you add ShowDebug("base_str %d",strbonus); above the skillratio assignment to test?

@Historica
Copy link
Author

In game test with current formula. Lv 1 cart tornado with Lv 5 cart remodeling and full cart (10500/10500)

1 base str , 150 bonus str , 37883 damage
http://114.imagebam.com/download/087LO_XqzaOudG89z-nmgQ/43128/431270826/screenNTRO010.jpg

130 base str , 2558 damage
http://113.imagebam.com/download/4lKDpS8khuwIE-7i8VK0pw/43128/431272129/screenNTRO012.jpg

@MishimaHaruna MishimaHaruna added type:bug Issue is a bug or describes an incorrect behavior that should be fixed component:mechanics Affecting the game mechanics in general labels Aug 29, 2015
@MrKeiKun
Copy link
Contributor

#2927 should fix this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:mechanics Affecting the game mechanics in general type:bug Issue is a bug or describes an incorrect behavior that should be fixed
Projects
None yet
Development

No branches or pull requests

4 participants