Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monster Ticket has no trade restrictions #2985

Closed
olsonpm opened this issue Apr 20, 2021 · 5 comments
Closed

Monster Ticket has no trade restrictions #2985

olsonpm opened this issue Apr 20, 2021 · 5 comments

Comments

@olsonpm
Copy link
Contributor

olsonpm commented Apr 20, 2021

Describe the bug
Monster Ticket has no trade restrictions

To Reproduce

  1. give yourself a ticket
@item Monster_Ticket
  1. view the item in your inventory to confirm the client "item moves description" shows that you cannot trade, drop, etc

  2. confirm you are able to drop the item

Expected behavior
You should not be able to drop a monster ticket

System specs (please complete the following information):

  • OS: windows 10 version 10.0.18363 Build 18363
  • Hercules Version v2021.03.08
  • Mode: pre-renewal
  • Packet version: 20200902
  • Client type: sak

Plugins used or source modifications
n/a

Additional context
the bug is in item_db.conf, both re/pre-re I believe it's supposed to have the same "Trade" block as the prize medal

e.g.

Trade: {
  nodrop: true
  notrade: true
  nocart: true
  nostorage: true
  nogstorage: true
  nomail: true
  noauction: true
}
@dastgirp
Copy link
Member

dastgirp commented Apr 20, 2021

The message depends on clientside itemmoveinfov5.txt.

Are you using latest kRO? if so, we can update item_db

@olsonpm
Copy link
Contributor Author

olsonpm commented Apr 20, 2021

The issue isn't the client file, it's the server settings. That item is not supposed to be trade'able etc.

@dastgirp
Copy link
Member

The issue isn't the client file, it's the server settings. That item is not supposed to be trade'able etc.

Yes, but your issue is based on what client shows. The question is, are you using kro files? As that would have updated trade restrictions. If you base this issue on custom clientside (translation , etc), then it's possible that they might be old/skewed.

@olsonpm
Copy link
Contributor Author

olsonpm commented Apr 20, 2021

No my issue is based off the server settings. To reproduce I show that the server settings are not in sync with the client. The file in use is from data.grf from a recent update of the kro client. The client file is correct

@dastgirp
Copy link
Member

dastgirp commented Apr 20, 2021

No my issue is based off the server settings. To reproduce I show that the server settings are not in sync with the client. The file in use is from data.grf from a recent update of the kro client. The client file is correct

Ok, that's what I meant to ask, if you are using recent update or not.
Thank you for confirming you are using recent grf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants