Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support Action Targeting WoW feature #2391

Open
4 tasks done
akari opened this issue Feb 11, 2023 · 4 comments
Open
4 tasks done

[FEATURE] Support Action Targeting WoW feature #2391

akari opened this issue Feb 11, 2023 · 4 comments
Assignees
Labels
enhancement triage Issue needs initial triage to determine if action needs to be taken.

Comments

@akari
Copy link

akari commented Feb 11, 2023

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this request and was not able to find one.
  • I edited the title of this feature request (above) so that it describes the issue I am reporting.

Feature Request

Dragonflight has introduced a new optional target selection system, Action Targeting. When using it, it often results in incorrect priority calculations in the addon.

This happens in relatively rare cases where normal targeting and soft targeting work at the same time. Although in normal situations the hard target takes priority over the soft target, this does not always work - for example when a hard target has an ally selected, or when a dead enemy is selected in the hard target. The latter situation happens quite often in AOE fights.

In this case the current target received through UnitID "target" will be incorrect, since in this situation the player will not actually interact with UnitID "target", but with UnitID "softenemy", but the priorities in the addon will be calculated for UnitID "target".

This problem is very easy to reproduce:

  • turn on Action Targeting in the settings
  • find a pack of several mobs and kill one of them
  • target a dead mob
  • turn towards the live mob so that it is selected as a "soft target"

After that the priorities will be calculated for the dead mob, and not for the one that is selected in the "soft target", as you can easily make sure simply by selecting these two mobs in turn in the "hard target" - the priority will change.

Additional Information

No response

Contact Information

Eugenio

@akari akari added enhancement triage Issue needs initial triage to determine if action needs to be taken. labels Feb 11, 2023
@Hekili
Copy link
Owner

Hekili commented Feb 11, 2023

image

I'll look into this.

@akari
Copy link
Author

akari commented Jul 2, 2023

There is an even better way to reproduce this bug

  • turn on Action Targeting in the settings
  • go to any target dummy area
  • target a friendly NPC
  • turn towards the hostile NPC so that it is selected as a "soft target"

After that the priorities will be calculated for the friendly NPC, and not for the one that is selected in the "soft target".

I made quick and dirty PR where this problem is solved (of course, there will need more changes in the code. this is just an example)

#2690

@akari
Copy link
Author

akari commented Jul 2, 2023

A screenshot illustrating the problem. "target" on the right, "softenemy" on top.

image

@Hekili
Copy link
Owner

Hekili commented Jul 2, 2023

There's no issue with replicating this; the addon is not designed for action targeting at present, and probably won't be until I overhaul the way additional targets work in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement triage Issue needs initial triage to determine if action needs to be taken.
Projects
None yet
Development

No branches or pull requests

2 participants