Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tool comment confuses some machines and simulators #426

Open
zio-pietro opened this issue Nov 13, 2019 · 2 comments
Open

Change tool comment confuses some machines and simulators #426

zio-pietro opened this issue Nov 13, 2019 · 2 comments

Comments

@zio-pietro
Copy link

Gcode postprocessors prepend comment to change tool command in form
(tool change to <tool name> (<tool type>) )
see nested parenthesis!
But according to infos found in net (for ex. cnczone.com)

Printable characters and white space inside parentheses is a comment. A left parenthesis always starts a comment. The comment ends at the first right parenthesis found thereafter.
Once a left parenthesis is placed on a line, a matching right parenthesis must appear before the end of the line. [multiline comments of type 'just a pair of brackets for all lines' aren't allowed]
Comments may not be nested; it is an error if a left parenthesis is found after the start of a comment and before the end of the comment.

(note and emphasis mine)

Not tried on my CNC mill yet, but simulator CAMotics refuse load that Gcode with errormsg

ERROR: Invalid character: ')'
ERROR: At: <gcode filename> <line>:<location of second right parenthesis>

Consistent with the cnczone comment, CAMotics parser closes comment at first occurrence of right parenthesis and a second one is considered as invalid character.

Q&D workaround: open gcode file with text editor and cancel guilty parenthesis ;)
Doing so every time is boring, so I suggest change comment form to

(tool change to <tool name> - <tool type>)

Just my 5 cents.

@zio-pietro
Copy link
Author

Oh, wrong place, it's heekscnc issue, sorry for it. :(
Can it be moved there or I must repost it?

@mehw
Copy link
Contributor

mehw commented Nov 14, 2019

Can it be moved there or I must repost it?

I think that the owner of the repos can move an issue from one to another: Transferring an issue to another repository

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants