Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include 'subscript' links #2

Open
HebeHH opened this issue Apr 26, 2021 · 0 comments
Open

Don't include 'subscript' links #2

HebeHH opened this issue Apr 26, 2021 · 0 comments

Comments

@HebeHH
Copy link
Owner

HebeHH commented Apr 26, 2021

The codebase works by assuming all links in a Wikipedia infobox table row are relevant to that keyword. This is not always the case.

Specific issue: Random notations in the row will include links.
For example, the Successor section for Laodice IV's position as consort gives Unknown, then notes (in notation format) that this is because the Antiochus V didn't marry.
image

In the graph, this turns into Antiochus V being her successor.
image

Useful note:
This specific kind of note is using the HTML format <small>:
image

Suggested fix:

  1. Ignore links inside <small> tags
  2. Ignore links inside brackets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant