Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : Crash detection / fallback to CLI #93

Open
HeatherComputer opened this issue Oct 7, 2024 · 2 comments
Open

Feature request : Crash detection / fallback to CLI #93

HeatherComputer opened this issue Oct 7, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@HeatherComputer
Copy link
Owner

Is your feature request related to a problem? Please describe.
Those on server hosts that give console access but not SSH access cannot access the CLI.

Describe the solution you'd like
Ideally, detecting a crash and prompting the user - say, "Crash detected, do you want to enter the restoration cli?" with an automatic exit if there's no response.

Additional context
Whilst porting + bugfixing in Polychat2, I learnt about the existence of shutdown hooks - simply put, you can have the JVM start a thread when it's in the shutdown phase, and the JVM will stay running until that thread terminates.
This thread here could make sure all other threads terminate, then ask the question about booting the CLI.

An example of polychat2's usage is here.

@HeatherComputer HeatherComputer added the enhancement New feature or request label Oct 7, 2024
@HeatherComputer
Copy link
Owner Author

@HoldYourWaffle I'd love your input here - my main concern is, how does one "detect" a crash?
And do you think the idea as a whole is good?

@HeatherComputer
Copy link
Owner Author

The CLI might also need a couple changes... it currently does expect to be running from the mods directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant