-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure auto-cleanup doesn't purge chained backups that are being relied on #5
Comments
I think the best idea is to introduce a user configuration option. |
I think it should take into account the max number of chains and how many chains there currently are. I don't ever see a case where a user would be happy with an entire chain being deleted if it's the ONLY chain, basically nuking all backups. So, if there's more than one incremental chain, delete the oldest one if necessary |
So :
Thoughts on this? |
Okay, this is now done - though, we do not have a good way to alert users. |
Maybe you could write it both to log, and also store the message to be displayed to an opped user at their logon? Also, not sure if this has been offered yet, but if you have a discord bot/webhook to give backup results inside of a discord channel, you could use that as another channel to relay this information to an admin. (or ofc other connectors, to maybe Matrix, IRC, or similar.) |
Auto-purge currently deletes the oldest backup.
This breaks differential and incremental chains.
Differentials are easy - if the oldest full backup is being relied on, delete the oldest non-full.
Incrementals however are a MAJOR problem.
With incrementals, the entire chain is linked - restoring a partial backup means also restoring every other partial backup since the last full backup, whereas differentials only require the last full backup.
As such, we have two options :
We could have a user config for this...?
The text was updated successfully, but these errors were encountered: