Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test connection #12

Merged
merged 10 commits into from
Dec 15, 2017
Merged

Test connection #12

merged 10 commits into from
Dec 15, 2017

Conversation

corentinheadoo
Copy link

  • test connection with ElasticSearch at start
  • better management between process: return the correct number of documents treated
  • clean some UT

@codecov
Copy link

codecov bot commented Oct 27, 2017

Codecov Report

Merging #12 into master will decrease coverage by 2.1%.
The diff coverage is 79.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
- Coverage     94.97%   92.87%   -2.11%     
- Complexity      110      132      +22     
============================================
  Files             9        9              
  Lines           418      449      +31     
============================================
+ Hits            397      417      +20     
- Misses           21       32      +11
Impacted Files Coverage Δ Complexity Δ
Helper/ElasticSearchHelper.php 100% <100%> (ø) 4 <2> (+1) ⬆️
EventListener/ElasticSearchListener.php 85% <100%> (-0.42%) 18 <0> (+1)
Command/PopulateElasticCommand.php 91.35% <77.55%> (-6.32%) 45 <7> (+15)
Command/AbstractCommand.php 90.47% <78.57%> (-2.68%) 31 <0> (+5)
Handler/ElasticSearchHandler.php 89.28% <0%> (-1.04%) 9% <0%> (ø)
Event/ElasticSearchEvent.php 100% <0%> (ø) 3% <0%> (ø) ⬇️
...pendencyInjection/HeadooElasticSearchExtension.php 100% <0%> (ø) 1% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5823e...930d833. Read the comment docs.

@corentinheadoo corentinheadoo merged commit 0d64f71 into master Dec 15, 2017
@corentinheadoo corentinheadoo deleted the cme-clean-test branch December 15, 2017 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant