Loosen Keras' version restriction, which is now unnecessarily strict #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehsiao
approved these changes
Oct 2, 2020
|
@lukehsiao thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problems or issues
Is your pull request related to a problem? Please describe.
The current version restriction on Keras (
keras==2.0.8) seems unnecessarily strict and is more likely to conflict with other packages.Does your pull request fix any issue.
N/A.
Description of the proposed changes
Loosen Keras' version restriction.
Test plan
A clear and concise description of how you test the new changes.
Correctly use the vision-based model at test_basic.py::test_visual_completion
Checklist