Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DataPanel returns dict for _state_keys, not set #223

Closed
gtmtg opened this issue Jan 25, 2022 · 1 comment
Closed

[BUG] DataPanel returns dict for _state_keys, not set #223

gtmtg opened this issue Jan 25, 2022 · 1 comment

Comments

@gtmtg
Copy link

gtmtg commented Jan 25, 2022

Describe the bug
DataPanel's default return type for _state_keys is an empty dict, not an empty set. This causes a crash for subclasses of DataPanel that attempt to union their _state_keys with super()'s _state_keys.

File ~/Dropbox/Projects/actively/lib/src/actively/datasets/columns.py:54, in ActivelyDataset._state_keys(cls)
     52 @classmethod
     53 def _state_keys(cls) -> Set[str]:
---> 54     return super(ActivelyDataset, cls)._state_keys().union({"name"})

AttributeError: 'dict' object has no attribute 'union'
@seyuboglu
Copy link
Collaborator

#224 just got merged into dev which should fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants