[ssl] Fix cert verification failure on clean windows environments #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses an mbedtls callback to call some windows api functions if verification fails, which avoids certain failures in clean windows environments.
tobil4sk
force-pushed
the
fix/windows-cert-verification
branch
from
ec9c7db
to
fb16330
Compare
Huh... |
|
Not sure why appveyor decided to have a say about it 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses an mbedtls callback to call some windows api functions if verification fails, which avoids certain failures in clean windows environments.
See similar haxe interp target PR for rationale and more info: HaxeFoundation/haxe#11838
Closes #196