Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hxjava-std.lib update #27

Closed
Simn opened this issue Mar 23, 2019 · 3 comments · Fixed by #28
Closed

hxjava-std.lib update #27

Simn opened this issue Mar 23, 2019 · 3 comments · Fixed by #28

Comments

@Simn
Copy link
Member

Simn commented Mar 23, 2019

I have just reverted #25 with a force-push to avoid having the file in the git history. I checked the previous version and found that it had the Code attributes stripped, which greatly decreases the file size. Since we don't need this information, we should do this for the updated version as well.

There's probably some tool to do that, but I'm not very familiar with Java tooling. If anyone has some knowledge here, please share it.

@nadako
Copy link
Member

nadako commented Mar 23, 2019

Oh, so what we had is a signature-only version without the actual bytecode? That's nice, we should do that with the new version!

@posxposy
Copy link
Contributor

What about @nadako proposal about using rt.jar from Java installation directory instead of keeping it directly in hxjava repo?
That's opening possibilities to use any version of Java you need, not just Java 8.

@Simn
Copy link
Member Author

Simn commented Mar 23, 2019

This issue is about the file being unnecessarily big, using it from a different source wouldn't help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants