Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip comments from extraParams.hxml for haxelib path #439

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Strip comments from extraParams.hxml for haxelib path #439

merged 2 commits into from
Feb 5, 2019

Conversation

Gama11
Copy link
Member

@Gama11 Gama11 commented Feb 5, 2019

Haxe doesn't expect comments here, so they end up in the list of classpaths for libs like hxnodejs.

There's a space expected in runVersion, but how could that be there still after a trim()?
@Simn Simn merged commit 9c66160 into HaxeFoundation:development Feb 5, 2019
@Gama11 Gama11 deleted the extraParamsComments branch February 5, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants