Add tests for broken git dependency failures

HaxeFoundation · Aug 7, 2022 · 39e395d · 39e395d
1 parent f28a4c8
commit 39e395d
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 0 deletions.
diff --git a/test/libraries/libBrokenDep/haxelib.json b/test/libraries/libBrokenDep/haxelib.json
@@ -0,0 +1,12 @@
+{
+	"name": "Foo",
+	"url" : "http://example.org",
+	"license": "GPL",
+	"tags": ["foo", "test"],
+	"description": "This project has a git dependency with a non-existent url",
+	"version": "1.0.0",
+	"dependencies": {
+		"Bar": "git:./libraries/broken-git-dep"
+	},
+	"contributors": ["Foo"]
+}
diff --git a/test/tests/integration/TestGit.hx b/test/tests/integration/TestGit.hx
@@ -12,11 +12,13 @@ class TestGit extends TestVcs {
 
 		makeGitRepo(vcsLibPath);
 		makeGitRepo(vcsLibNoHaxelibJson);
+		makeGitRepo(vcsBrokenDependency);
 	}
 
 	override function tearDown() {
 		resetGitRepo(vcsLibPath);
 		resetGitRepo(vcsLibNoHaxelibJson);
+		resetGitRepo(vcsBrokenDependency);
 
 		super.tearDown();
 	}

diff --git a/test/tests/integration/TestHg.hx b/test/tests/integration/TestHg.hx
@@ -12,11 +12,13 @@ class TestHg extends TestVcs {
 
 		makeHgRepo(vcsLibPath);
 		makeHgRepo(vcsLibNoHaxelibJson);
+		makeHgRepo(vcsBrokenDependency);
 	}
 
 	override function tearDown() {
 		resetHgRepo(vcsLibPath);
 		resetHgRepo(vcsLibNoHaxelibJson);
+		resetHgRepo(vcsBrokenDependency);
 
 		super.tearDown();
 	}

diff --git a/test/tests/integration/TestInstall.hx b/test/tests/integration/TestInstall.hx
@@ -246,4 +246,12 @@ class TestInstall extends IntegrationTests {
 		assertTrue(r.out.indexOf("[hg]") >= 0);
 		assertSuccess(r);
 	}
+
+	function testLocalWithBrokenDependency() {
+
+		final r = haxelib(["install", "libraries/libBrokenDep.zip"]).result();
+		assertFail(r);
+		assertOutputEquals(["Error: Failed installing dependencies for Foo:", "Could not clone Git repository."], r.err.trim());
+
+	}
 }
diff --git a/test/tests/integration/TestVcs.hx b/test/tests/integration/TestVcs.hx
@@ -5,6 +5,7 @@ abstract class TestVcs extends IntegrationTests {
 
 	final vcsLibPath = "libraries/libBar";
 	final vcsLibNoHaxelibJson = "libraries/libNoHaxelibJson";
+	final vcsBrokenDependency = "libraries/libBrokenDep";
 
 	function new(cmd:String) {
 		super();
@@ -122,4 +123,16 @@ abstract class TestVcs extends IntegrationTests {
 		assertSuccess(r);
 		assertTrue(r.out.indexOf("lib//") < 0);
 	}
+
+	function testBrokenDependency() {
+
+		final r = haxelib([cmd, "Foo", vcsBrokenDependency]).result();
+		assertFail(r);
+		assertOutputEquals([
+			"Error: Failed installing dependencies for Foo:",
+			"Could not clone Git repository."
+		], r.err.trim());
+
+	}
+
 }