Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[display] expose list of metadata/defines #11399

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Nov 20, 2023

Will allow implementing support on editor side, like vshaxe/vshaxe#580

@kLabz kLabz added this to the 4.3 Hotfix candidates milestone Nov 20, 2023
std/haxe/display/Display.hx Outdated Show resolved Hide resolved
@kLabz
Copy link
Contributor Author

kLabz commented Nov 21, 2023

On a side note, we have this in haxe LSP which would be nice to be able to define directly in meta/define documentation (both compiler and user provided ones):

https://github.com/vshaxe/haxe-language-server/blob/5d0e083e374b4881d232349920c320a42845db5f/src/haxeLanguageServer/features/hxml/data/Defines.hx#L132-L155

@Simn Simn merged commit 80000c1 into development Nov 21, 2023
119 of 120 checks passed
@skial skial mentioned this pull request Nov 28, 2023
1 task
0b1kn00b pushed a commit to 0b1kn00b/haxe that referenced this pull request Jan 25, 2024
* [display] expose meta list (including user defined ones)

* [display] expose defines list (including user defined ones)

* add user vs compiler filtering

* cleanup
@kLabz kLabz mentioned this pull request Feb 18, 2024
19 tasks
kLabz added a commit that referenced this pull request Feb 18, 2024
* [display] expose meta list (including user defined ones)

* [display] expose defines list (including user defined ones)

* add user vs compiler filtering

* cleanup
@kLabz kLabz removed this from the 4.3 Hotfix candidates milestone Feb 18, 2024
kLabz added a commit that referenced this pull request Mar 4, 2024
* [display] expose meta list (including user defined ones)

* [display] expose defines list (including user defined ones)

* add user vs compiler filtering

* cleanup
@kLabz kLabz deleted the feature/display-api-metadata-defines branch May 28, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants