Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull requests for 4.3 Hotfix (part 4) #11394

Closed
9 tasks done
kLabz opened this issue Nov 19, 2023 · 10 comments · Fixed by #11583
Closed
9 tasks done

Pull requests for 4.3 Hotfix (part 4) #11394

kLabz opened this issue Nov 19, 2023 · 10 comments · Fixed by #11583
Assignees

Comments

@kLabz kLabz added this to the 4.3 Hotfix milestone Nov 19, 2023
@kLabz kLabz self-assigned this Nov 19, 2023
@RblSb
Copy link
Member

RblSb commented Nov 21, 2023

Not sure if possible to merge, but compilation server improvements will be nice to have for stable releases before 5.0
486dfc8

@kLabz
Copy link
Contributor Author

kLabz commented Feb 18, 2024

Not sure if possible to merge, but compilation server improvements will be nice to have for stable releases before 5.0 486dfc8

I didn't include this, as it's kind of a big change (and big merge conflicts) for a patch release :/

@tobil4sk
Copy link
Member

Could the next 4.3 release include Apple Silicon binaries as well? #11572

@kLabz
Copy link
Contributor Author

kLabz commented Feb 28, 2024

I will try, iirc there were issues last time.

Btw, I've seen people complain about the installer not being "universal", do you think it would be easy to update?

@tobil4sk
Copy link
Member

Btw, I've seen people complain about the installer not being "universal", do you think it would be easy to update?

I guess we'd need Neko universal binaries too.

@kLabz
Copy link
Contributor Author

kLabz commented Mar 4, 2024

This will have to wait for 4.3.5

@kLabz kLabz linked a pull request Mar 4, 2024 that will close this issue
19 tasks
@kLabz kLabz closed this as completed Mar 4, 2024
@kLabz kLabz removed this from the 4.3 Hotfix milestone Mar 4, 2024
@RblSb
Copy link
Member

RblSb commented Apr 21, 2024

#11177 is broken in release
UPD: this is 486dfc8, nevermind

@RblSb
Copy link
Member

RblSb commented May 16, 2024

Null coalescing logic has not been updated in release branch:

@:using(Main.MoneyTools)
typedef Money = Int;

class MoneyTools {
	public static function inflate(money:Money):Money {
		return money + 99;
	}
}

class Main {
	static final money:Null<Money> = 1; // ok without Null<...>

	static function main() {
		final money = money ?? return;
		$type(money); // Int
		money.inflate(); // Missing fields for this
	}
}

@kLabz
Copy link
Contributor Author

kLabz commented May 16, 2024

What issue/PR are you talking about here?

@RblSb
Copy link
Member

RblSb commented May 16, 2024

I think this is about commits from #11425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants