Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix positions #488

Merged
merged 4 commits into from
Nov 4, 2019
Merged

Fix positions #488

merged 4 commits into from
Nov 4, 2019

Conversation

AlexHaxe
Copy link
Member

@AlexHaxe AlexHaxe commented Nov 3, 2019

No description provided.

e.g. only mark function signature instead of whole function incl. body
vscode extension (and others) can manage hash cache from outside
making sure cache doesn't grow indefinitely
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #488 into dev will decrease coverage by <.01%.
The diff coverage is 97.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #488      +/-   ##
=========================================
- Coverage   97.3%   97.29%   -0.01%     
=========================================
  Files        105      106       +1     
  Lines       6743     6759      +16     
  Branches     917      917              
=========================================
+ Hits        6561     6576      +15     
  Misses       182      182              
- Partials       0        1       +1
Impacted Files Coverage Δ
...eckstyle/checks/modifier/RedundantModifierCheck.hx 100% <100%> (ø) ⬆️
src/checkstyle/checks/size/MethodLengthCheck.hx 100% <100%> (ø) ⬆️
src/checkstyle/checks/coding/ReturnCountCheck.hx 100% <100%> (ø) ⬆️
src/checkstyle/checks/size/ParameterNumberCheck.hx 100% <100%> (ø) ⬆️
...rc/checkstyle/checks/coding/CodeSimilarityCheck.hx 98.8% <100%> (+0.04%) ⬆️
...checkstyle/checks/comments/FieldDocCommentCheck.hx 98.02% <100%> (+0.32%) ⬆️
src/checkstyle/utils/PosHelper.hx 96% <96%> (ø)
src/checkstyle/checks/modifier/FinalCheck.hx 96.42% <0%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fc74a...b8d6086. Read the comment docs.

@AlexHaxe AlexHaxe merged commit 4befddc into HaxeCheckstyle:dev Nov 4, 2019
@AlexHaxe AlexHaxe deleted the fix_positions branch November 4, 2019 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant