Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added parameter check to FieldDocComment check, fixes #87 #444

Merged
merged 3 commits into from
Jun 25, 2018

Conversation

AlexHaxe
Copy link
Member

adjusted autodetection for nested check
fixed reported position of EmptyBlock check

adjusted autodetection for nested check
fixed reported position of EmptyBlock check
@ghost ghost assigned AlexHaxe Jun 25, 2018
@ghost ghost added the in progress label Jun 25, 2018
@codecov-io
Copy link

codecov-io commented Jun 25, 2018

Codecov Report

Merging #444 into dev will decrease coverage by 0.08%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #444      +/-   ##
=========================================
- Coverage   92.29%   92.2%   -0.09%     
=========================================
  Files          93      95       +2     
  Lines        9201    9267      +66     
  Branches      349     355       +6     
=========================================
+ Hits         8492    8545      +53     
- Misses        388     401      +13     
  Partials      321     321
Impacted Files Coverage Δ
...rc/checkstyle/checks/coding/NestedForDepthCheck.hx 100% <100%> (ø) ⬆️
src/checkstyle/checks/coding/NestedIfDepthCheck.hx 100% <100%> (ø) ⬆️
...rc/checkstyle/checks/coding/NestedTryDepthCheck.hx 100% <100%> (ø) ⬆️
...c/checkstyle/checks/whitespace/ListOfEmptyLines.hx 93.08% <100%> (ø) ⬆️
src/checkstyle/checks/block/EmptyBlockCheck.hx 87.85% <100%> (ø) ⬆️
...checkstyle/checks/comments/FieldDocCommentCheck.hx 94.48% <87.27%> (-1.79%) ⬇️
src/checkstyle/utils/Mutex.hx 100% <0%> (ø)
src/checkstyle/utils/Thread.hx 0% <0%> (ø)
src/checkstyle/checks/imports/UnusedImportCheck.hx 96.01% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d25b3f...70766c0. Read the comment docs.

@AlexHaxe AlexHaxe merged commit b49d9c3 into HaxeCheckstyle:dev Jun 25, 2018
@AlexHaxe AlexHaxe deleted the check_doc_params branch June 25, 2018 22:51
@ghost ghost removed the in progress label Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants