Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report character pos instead of byte pos #435

Merged
merged 2 commits into from
Jun 10, 2018

Conversation

AlexHaxe
Copy link
Member

No description provided.

@ghost ghost assigned AlexHaxe Jun 10, 2018
@ghost ghost added the in progress label Jun 10, 2018
@codecov-io
Copy link

codecov-io commented Jun 10, 2018

Codecov Report

Merging #435 into dev will decrease coverage by 0.01%.
The diff coverage is 96.77%.

Impacted file tree graph

@@           Coverage Diff            @@
##            dev     #435      +/-   ##
========================================
- Coverage    92%   91.99%   -0.02%     
========================================
  Files        90       90              
  Lines      8657     8666       +9     
  Branches    328      330       +2     
========================================
+ Hits       7965     7972       +7     
  Misses      392      392              
- Partials    300      302       +2
Impacted Files Coverage Δ
...rc/checkstyle/checks/whitespace/EmptyLinesCheck.hx 99.36% <100%> (ø) ⬆️
...style/checks/whitespace/ExtendedEmptyLinesCheck.hx 95.08% <100%> (-0.01%) ⬇️
...c/checkstyle/checks/whitespace/IndentationCheck.hx 96.64% <100%> (ø) ⬆️
src/checkstyle/checks/size/LineLengthCheck.hx 97.82% <100%> (ø) ⬆️
...style/checks/whitespace/TrailingWhitespaceCheck.hx 96.96% <100%> (ø) ⬆️
...heckstyle/checks/whitespace/TabForAligningCheck.hx 100% <100%> (ø) ⬆️
src/checkstyle/checks/size/FileLengthCheck.hx 100% <100%> (ø) ⬆️
src/checkstyle/checks/design/EmptyPackageCheck.hx 100% <100%> (ø) ⬆️
...yle/checks/whitespace/IndentationCharacterCheck.hx 97.95% <100%> (ø) ⬆️
src/checkstyle/checks/Check.hx 84.53% <92.85%> (+0.13%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5024bfe...18f0233. Read the comment docs.

@AlexHaxe AlexHaxe merged commit 0c0325b into HaxeCheckstyle:dev Jun 10, 2018
@ghost ghost removed the in progress label Jun 10, 2018
@AlexHaxe AlexHaxe deleted the fix_reported_char_positions branch June 10, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants