Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haxe 4 shouldn't be failing anymore #425

Merged
merged 4 commits into from
May 27, 2018
Merged

Haxe 4 shouldn't be failing anymore #425

merged 4 commits into from
May 27, 2018

Conversation

Gama11
Copy link
Member

@Gama11 Gama11 commented May 27, 2018

@codecov-io
Copy link

codecov-io commented May 27, 2018

Codecov Report

Merging #425 into dev will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #425      +/-   ##
==========================================
- Coverage   91.33%   91.28%   -0.06%     
==========================================
  Files         126      128       +2     
  Lines        9255     9270      +15     
  Branches      326      331       +5     
==========================================
+ Hits         8453     8462       +9     
- Misses        512      519       +7     
+ Partials      290      289       -1
Impacted Files Coverage Δ
src/checkstyle/utils/Thread.hx 0% <0%> (ø)
src/checkstyle/utils/Mutex.hx 100% <0%> (ø)
src/checkstyle/checks/imports/UnusedImportCheck.hx 95.78% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b80f8c...09a6928. Read the comment docs.

@Gama11
Copy link
Member Author

Gama11 commented May 27, 2018

@Gama11 Gama11 merged commit 641069c into HaxeCheckstyle:dev May 27, 2018
@Gama11 Gama11 deleted the haxe4 branch May 27, 2018 16:02
@AlexHaxe
Copy link
Member

yeah when running in eval it doesn't show a text report...
I had to reroute report generation for eval because otherwise it wouldn't finish and the completionHandler would never get called.
I haven't looked into it, but I guess it has to do with no thread support or some other detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants