Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored to use Bytes instead of String for file contents, see #98 #402

Merged
merged 3 commits into from
May 1, 2018

Conversation

AlexHaxe
Copy link
Member

@AlexHaxe AlexHaxe commented May 1, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #402 into dev will decrease coverage by 0.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #402      +/-   ##
==========================================
- Coverage   90.78%   90.76%   -0.02%     
==========================================
  Files         119      119              
  Lines        7869     7875       +6     
  Branches      299      301       +2     
==========================================
+ Hits         7144     7148       +4     
  Misses        462      462              
- Partials      263      265       +2
Impacted Files Coverage Δ
src/checkstyle/checks/imports/UnusedImportCheck.hx 95.08% <0%> (ø) ⬆️
...heckstyle/checks/whitespace/WhitespaceCheckBase.hx 89.28% <100%> (+0.12%) ⬆️
...rc/checkstyle/checks/literal/StringLiteralCheck.hx 96.55% <100%> (ø) ⬆️
src/checkstyle/checks/block/RightCurlyCheck.hx 96.89% <100%> (ø) ⬆️
src/checkstyle/utils/StringUtils.hx 53.33% <100%> (+3.33%) ⬆️
...eckstyle/checks/whitespace/WhitespaceAfterCheck.hx 56.84% <100%> (ø) ⬆️
src/checkstyle/checks/whitespace/WrapCheckBase.hx 98% <100%> (+0.04%) ⬆️
...ckstyle/checks/whitespace/WhitespaceAroundCheck.hx 88.11% <100%> (+0.08%) ⬆️
...kstyle/checks/block/ConditionalCompilationCheck.hx 96.35% <100%> (ø) ⬆️
...c/checkstyle/checks/whitespace/ArrayAccessCheck.hx 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d5fc4...cb55a41. Read the comment docs.

@AlexHaxe AlexHaxe merged commit 7aa7a85 into HaxeCheckstyle:dev May 1, 2018
@AlexHaxe AlexHaxe deleted the fix_vscode_umlaut branch May 1, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants