fix: Fixed rare issue with oneOf usage to define required property.

tryAGI · Aug 31, 2024 · a551442 · a551442
1 parent 462afa7
commit a551442
Show file tree

Hide file tree

Showing 15 changed files with 33 additions and 5 deletions.
diff --git a/src/libs/OpenApiGenerator.Core/Models/TypeData.cs b/src/libs/OpenApiGenerator.Core/Models/TypeData.cs
@@ -155,9 +155,15 @@ Default with
             IsDateTime: context.Schema.IsDateTime(),
             IsBinary: context.Schema.IsBinary(),
             IsUnixTimestamp: context.Schema.IsUnixTimestamp(),
-            AnyOfCount: context.Schema.AnyOf?.Count ?? 0,
-            OneOfCount: context.Schema.OneOf?.Count ?? 0,
-            AllOfCount: context.Schema.AllOf?.Count ?? 0,
+            AnyOfCount: context.Schema.IsAnyOf() // Sometimes here AnyOf with only required properties
+                ? context.Schema.AnyOf?.Count ?? 0
+                : 0,
+            OneOfCount: context.Schema.IsOneOf() // Sometimes here OneOf with only required properties
+                ? context.Schema.OneOf?.Count ?? 0
+                : 0,
+            AllOfCount: context.Schema.IsAllOf() // Sometimes here AllOf with only required properties
+                ? context.Schema.AllOf?.Count ?? 0
+                : 0,
             IsComponent: context.IsComponent,
             Properties: properties,
             EnumValues: enumValues,

diff --git a/...SnapshotTests/Snapshots/GitHub/NewtonsoftJson/_#G.ChecksClient.ChecksCreate.g.verified.cs b/...SnapshotTests/Snapshots/GitHub/NewtonsoftJson/_#G.ChecksClient.ChecksCreate.g.verified.cs
@@ -44,6 +44,8 @@ partial void ProcessChecksCreateResponseContent(
             global::G.ChecksCreateRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PrepareChecksCreateArguments(

diff --git a/...SnapshotTests/Snapshots/GitHub/NewtonsoftJson/_#G.ChecksClient.ChecksUpdate.g.verified.cs b/...SnapshotTests/Snapshots/GitHub/NewtonsoftJson/_#G.ChecksClient.ChecksUpdate.g.verified.cs
@@ -47,6 +47,8 @@ partial void ProcessChecksUpdateResponseContent(
             global::G.ChecksUpdateRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PrepareChecksUpdateArguments(

diff --git a/...Hub/NewtonsoftJson/_#G.CodeScanningClient.CodeScanningCreateVariantAnalysis.g.verified.cs b/...Hub/NewtonsoftJson/_#G.CodeScanningClient.CodeScanningCreateVariantAnalysis.g.verified.cs
@@ -45,6 +45,8 @@ partial void ProcessCodeScanningCreateVariantAnalysisResponseContent(
             global::G.CodeScanningCreateVariantAnalysisRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PrepareCodeScanningCreateVariantAnalysisArguments(

diff --git a/...Tests/Snapshots/GitHub/NewtonsoftJson/_#G.PullsClient.PullsRequestReviewers.g.verified.cs b/...Tests/Snapshots/GitHub/NewtonsoftJson/_#G.PullsClient.PullsRequestReviewers.g.verified.cs
@@ -46,6 +46,8 @@ partial void ProcessPullsRequestReviewersResponseContent(
             global::G.PullsRequestReviewersRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PreparePullsRequestReviewersArguments(

diff --git a/...tTests/Snapshots/GitHub/NewtonsoftJson/_#G.ReposClient.ReposCreatePagesSite.g.verified.cs b/...tTests/Snapshots/GitHub/NewtonsoftJson/_#G.ReposClient.ReposCreatePagesSite.g.verified.cs
@@ -43,6 +43,8 @@ partial void ProcessReposCreatePagesSiteResponseContent(
             global::G.ReposCreatePagesSiteRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PrepareReposCreatePagesSiteArguments(

diff --git a/.../GitHub/NewtonsoftJson/_#G.ReposClient.ReposUpdateInformationAboutPagesSite.g.verified.cs b/.../GitHub/NewtonsoftJson/_#G.ReposClient.ReposUpdateInformationAboutPagesSite.g.verified.cs
@@ -43,6 +43,8 @@ partial void ProcessReposUpdateInformationAboutPagesSiteResponseContent(
             global::G.ReposUpdateInformationAboutPagesSiteRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PrepareReposUpdateInformationAboutPagesSiteArguments(

diff --git a/...SnapshotTests/Snapshots/GitHub/SystemTextJson/_#G.ChecksClient.ChecksCreate.g.verified.cs b/...SnapshotTests/Snapshots/GitHub/SystemTextJson/_#G.ChecksClient.ChecksCreate.g.verified.cs
@@ -44,6 +44,8 @@ partial void ProcessChecksCreateResponseContent(
             global::G.ChecksCreateRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PrepareChecksCreateArguments(

diff --git a/...SnapshotTests/Snapshots/GitHub/SystemTextJson/_#G.ChecksClient.ChecksUpdate.g.verified.cs b/...SnapshotTests/Snapshots/GitHub/SystemTextJson/_#G.ChecksClient.ChecksUpdate.g.verified.cs
@@ -47,6 +47,8 @@ partial void ProcessChecksUpdateResponseContent(
             global::G.ChecksUpdateRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PrepareChecksUpdateArguments(

diff --git a/...Hub/SystemTextJson/_#G.CodeScanningClient.CodeScanningCreateVariantAnalysis.g.verified.cs b/...Hub/SystemTextJson/_#G.CodeScanningClient.CodeScanningCreateVariantAnalysis.g.verified.cs
@@ -45,6 +45,8 @@ partial void ProcessCodeScanningCreateVariantAnalysisResponseContent(
             global::G.CodeScanningCreateVariantAnalysisRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PrepareCodeScanningCreateVariantAnalysisArguments(

diff --git a/...Tests/Snapshots/GitHub/SystemTextJson/_#G.PullsClient.PullsRequestReviewers.g.verified.cs b/...Tests/Snapshots/GitHub/SystemTextJson/_#G.PullsClient.PullsRequestReviewers.g.verified.cs
@@ -46,6 +46,8 @@ partial void ProcessPullsRequestReviewersResponseContent(
             global::G.PullsRequestReviewersRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PreparePullsRequestReviewersArguments(

diff --git a/...tTests/Snapshots/GitHub/SystemTextJson/_#G.ReposClient.ReposCreatePagesSite.g.verified.cs b/...tTests/Snapshots/GitHub/SystemTextJson/_#G.ReposClient.ReposCreatePagesSite.g.verified.cs
@@ -43,6 +43,8 @@ partial void ProcessReposCreatePagesSiteResponseContent(
             global::G.ReposCreatePagesSiteRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PrepareReposCreatePagesSiteArguments(

diff --git a/.../GitHub/SystemTextJson/_#G.ReposClient.ReposUpdateInformationAboutPagesSite.g.verified.cs b/.../GitHub/SystemTextJson/_#G.ReposClient.ReposUpdateInformationAboutPagesSite.g.verified.cs
@@ -43,6 +43,8 @@ partial void ProcessReposUpdateInformationAboutPagesSiteResponseContent(
             global::G.ReposUpdateInformationAboutPagesSiteRequest request,
             global::System.Threading.CancellationToken cancellationToken = default)
         {
+            request = request ?? throw new global::System.ArgumentNullException(nameof(request));
+
             PrepareArguments(
                 client: _httpClient);
             PrepareReposUpdateInformationAboutPagesSiteArguments(

diff --git a/...pshots/OpenAi/SystemTextJson/_#G.Models.CreateAssistantRequestToolResources.g.verified.cs b/...pshots/OpenAi/SystemTextJson/_#G.Models.CreateAssistantRequestToolResources.g.verified.cs
@@ -19,7 +19,6 @@ public sealed partial class CreateAssistantRequestToolResources
         /// 
         /// </summary>
         [global::System.Text.Json.Serialization.JsonPropertyName("file_search")]
-        [global::System.Text.Json.Serialization.JsonConverter(typeof(global::OpenApiGenerator.JsonConverters.OneOfJsonConverterFactory2))]
         public global::G.CreateAssistantRequestToolResourcesFileSearch? FileSearch { get; set; }
 
         /// <summary>

diff --git a/...Snapshots/OpenAi/SystemTextJson/_#G.Models.CreateThreadRequestToolResources.g.verified.cs b/...Snapshots/OpenAi/SystemTextJson/_#G.Models.CreateThreadRequestToolResources.g.verified.cs
@@ -19,7 +19,6 @@ public sealed partial class CreateThreadRequestToolResources
         /// 
         /// </summary>
         [global::System.Text.Json.Serialization.JsonPropertyName("file_search")]
-        [global::System.Text.Json.Serialization.JsonConverter(typeof(global::OpenApiGenerator.JsonConverters.OneOfJsonConverterFactory2))]
         public global::G.CreateThreadRequestToolResourcesFileSearch? FileSearch { get; set; }
 
         /// <summary>