Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: verify is tx is confirmed before getting nc state #695

Merged
merged 10 commits into from
Dec 11, 2024
Merged

feat: verify is tx is confirmed before getting nc state #695

merged 10 commits into from
Dec 11, 2024

Conversation

pedroferreira1
Copy link
Member

Acceptance Criteria

  • Verify if transaction is confirmed before getting nc state and history. If it's not confirmed, add a loading and keep polling the data.

The currently screen when we get the state before the tx is confirmed

image

New screen waiting confirmation

image

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@pedroferreira1 pedroferreira1 self-assigned this Nov 14, 2024
@pedroferreira1 pedroferreira1 force-pushed the feat/nc-state-wait-tx-confirmed branch from 68e9baa to ab4ef78 Compare December 3, 2024 22:48
andreabadesso
andreabadesso reviewed Dec 9, 2024
View reviewed changes
src/constants.js Outdated Show resolved Hide resolved
src/sagas/nanoContract.js Outdated Show resolved Hide resolved
src/actions/index.js Outdated Show resolved Hide resolved
src/screens/nano-contract/NanoContractDetail.js Outdated Show resolved Hide resolved
src/screens/nano-contract/NanoContractDetail.js Outdated Show resolved Hide resolved
src/screens/nano-contract/NanoContractDetail.js Outdated Show resolved Hide resolved
tuliomir
tuliomir approved these changes Dec 9, 2024
View reviewed changes
src/actions/index.js Outdated Show resolved Hide resolved
@pedroferreira1 pedroferreira1 force-pushed the feat/nc-state-wait-tx-confirmed branch from f29c14b to 0d4c26a Compare December 9, 2024 15:39
@pedroferreira1 pedroferreira1 force-pushed the feat/nc-state-wait-tx-confirmed branch from 849952f to 7f288d2 Compare December 11, 2024 00:35
@pedroferreira1 pedroferreira1 merged commit d559b80 into master Dec 11, 2024
4 checks passed
@pedroferreira1 pedroferreira1 deleted the feat/nc-state-wait-tx-confirmed branch December 11, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreabadesso andreabadesso andreabadesso approved these changes

@tuliomir tuliomir tuliomir approved these changes

Assignees

@pedroferreira1 pedroferreira1

Labels
None yet
Projects
Hathor Network
Status: Waiting to be deployed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedroferreira1 @tuliomir @andreabadesso