Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrades redux #595

Merged
merged 2 commits into from
May 2, 2024
Merged

chore: Upgrades redux #595

merged 2 commits into from
May 2, 2024

Conversation

tuliomir
Copy link
Collaborator

@tuliomir tuliomir commented Apr 29, 2024

This PR upgrades the Redux version of this application from v4 to v5, but instead of keeping it a direct rependency, replaces it with redux-toolkit that indirectly uses redux. This is the strongly recommended approach by the current Redux docs.

This is the first step needed for the broader refactoring of the redux code proposed by #507 , aiming to bring this code to more up to date best practices for Redux.

Acceptance Criteria

  • Upgrades the Redux dependency

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Apr 29, 2024
@tuliomir tuliomir self-assigned this Apr 29, 2024
@tuliomir tuliomir marked this pull request as ready for review April 30, 2024 15:10
@tuliomir tuliomir removed the request for review from pedroferreira1 April 30, 2024 15:11
@tuliomir tuliomir force-pushed the chore/redux-toolkit branch from 2a1f2dc to 6e5d8cb Compare April 30, 2024 16:09
src/store/index.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@tuliomir tuliomir force-pushed the chore/redux-toolkit branch from e4303a2 to aa5fa4f Compare April 30, 2024 16:26
@tuliomir tuliomir requested a review from andreabadesso April 30, 2024 16:27
@tuliomir tuliomir merged commit d69f11d into master May 2, 2024
1 check passed
@tuliomir tuliomir deleted the chore/redux-toolkit branch May 2, 2024 16:18
@tuliomir tuliomir mentioned this pull request May 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants