Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing navigation calls #594

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Fix: Missing navigation calls #594

merged 3 commits into from
Apr 30, 2024

Conversation

tuliomir
Copy link
Collaborator

Two instances of navigation calls were missed during the refactor of #555 . Those should be corrected so that all navigation calls work accordingly.

Acceptance Criteria

  • All navigation requests within the application should use the useNavigate hook

Notes

Since the ModalUnhandledError component is quite simple, I took the opportunity to also refactor it to a functional component. The TxData component, however, is complex enough to deserve its own PR in a future moment, so I only made the smallest adjustment to fix the issue.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the bug Something isn't working label Apr 29, 2024
@tuliomir tuliomir requested a review from andreabadesso April 29, 2024 17:02
@tuliomir tuliomir self-assigned this Apr 29, 2024
@tuliomir tuliomir requested review from alexruzenhack and removed request for pedroferreira1 April 29, 2024 17:02
Copy link
Collaborator

@alexruzenhack alexruzenhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a suggestion.

src/components/ModalUnhandledError.js Outdated Show resolved Hide resolved
@tuliomir tuliomir merged commit a968e67 into master Apr 30, 2024
1 check passed
@tuliomir tuliomir deleted the fix/history-push branch April 30, 2024 15:58
@tuliomir tuliomir mentioned this pull request May 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants